Skip to content

Fix deprecation warning using raw str#140

Closed
sloretz wants to merge 1 commit intomasterfrom
sloretz/deprecation_warning_raw_str
Closed

Fix deprecation warning using raw str#140
sloretz wants to merge 1 commit intomasterfrom
sloretz/deprecation_warning_raw_str

Conversation

@sloretz
Copy link
Contributor

@sloretz sloretz commented May 7, 2019

This fixes a deprecation warning when building ament_lint_cmake on windows 10 using python 3.7.3

C:\ros2_ws\build\ament_lint_cmake\build\bdist.win-amd64\egg\ament_lint_cmake\cmakelint.py:124: DeprecationWarning: invalid escape sequence \.
  package = re.sub('^Find(.*)\.cmake', lambda m: m.group(1), package)
C:\ros2_ws\build\ament_lint_cmake\build\bdist.win-amd64\egg\ament_lint_cmake\cmakelint.py:335: DeprecationWarning: invalid escape sequence \.
  name_match = re.match('Find(.*)\.cmake', os.path.basename(filename))

@sloretz
Fix deprecation warning using raw str
7a2ebff 
Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
@sloretz sloretz added the in review Waiting for review (Kanban column) label May 7, 2019
@sloretz sloretz self-assigned this May 7, 2019
@dirk-thomas
Copy link
Contributor

dirk-thomas commented May 7, 2019

Have these changes been contributed upstream? If not I would recommend that and once they have been accepted we can pull an updated version.

@sloretz
Copy link
Contributor Author

sloretz commented May 7, 2019 •
edited
Loading

I didn't realize this file was taken from another repo. It looks like cmakelint is available on pip PyPI, any reason not to use that?

@dirk-thomas
Copy link
Contributor

dirk-thomas commented May 8, 2019

It looks like cmakelint is available on PyPI, any reason not to use that?

We need it to be a Debian package in order to depend on it in a Debian package.

@hidmic
Copy link
Contributor

hidmic commented Jul 30, 2019

Hmm, isn't this already in master?

@sloretz
Copy link
Contributor Author

sloretz commented Jul 31, 2019

Replaced by #144

@sloretz sloretz closed this Jul 31, 2019
@sloretz sloretz deleted the sloretz/deprecation_warning_raw_str branch July 31, 2019 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sloretz sloretz

Labels

in review Waiting for review (Kanban column)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sloretz @dirk-thomas @hidmic